perdedora
  • 🍉

  • Joined on 2025-02-20
perdedora created branch embed-fixes in perdedora/leftypol 2025-04-02 07:12:10 -05:00
perdedora pushed to embed-fixes at perdedora/leftypol 2025-04-02 07:12:10 -05:00
9f9fba63d9 HttpDriver.php: fix download max size logic
a5770a2de5 EmbedService.php: remove extra check for thumbnail fallback
871e8d78dc context.php: inject missing dependencies to EmbedService.php
9df6cdbf28 EmbedService.php: add missing dependencies
Compare 4 commits »
perdedora created repository perdedora/leftypol 2025-04-02 06:57:20 -05:00
perdedora commented on pull request leftypol/leftypol#112 2025-04-01 10:15:02 -05:00
WIP: extend the embed functionality

only got the download to work by changing (int)($dl <= $this->max_file_size) to (int)($dl > $this->max_file_size)

perdedora commented on pull request leftypol/leftypol#112 2025-04-01 10:03:06 -05:00
WIP: extend the embed functionality

$this->http is never initialized as well

perdedora commented on pull request leftypol/leftypol#112 2025-03-29 16:42:50 -05:00
WIP: extend the embed functionality

in the current architecture this doesnt fit here. we would need to initiate embed service in display just to do a replace

perdedora commented on pull request leftypol/leftypol#112 2025-03-29 16:42:50 -05:00
WIP: extend the embed functionality

$this->tmp_dir is never initialized causing an error

perdedora commented on pull request leftypol/leftypol#112 2025-03-29 16:42:50 -05:00
WIP: extend the embed functionality

eh, you could create a generic fallback outside of the array instead of putting a fallback for each embedding. customization is cool and all, but will you really create images for all embeds?

perdedora commented on pull request leftypol/leftypol#112 2025-03-29 16:42:50 -05:00
WIP: extend the embed functionality

you could remove fallback from here. if an embed doesnt have a fallback it simply fail without ever trying to run. and you already check for a fallback at line 121

perdedora commented on pull request leftypol/leftypol#112 2025-03-23 15:33:48 -05:00
WIP: extend the embed functionality

The return must be $resp

perdedora commented on pull request leftypol/leftypol#112 2025-03-23 14:33:02 -05:00
WIP: extend the embed functionality

There's two cache keys. One at line 30 and another one at 58. both are differently

perdedora commented on pull request leftypol/leftypol#112 2025-03-23 14:33:02 -05:00
WIP: extend the embed functionality

This returns an object causing everything else to fail

perdedora commented on pull request leftypol/leftypol#112 2025-03-23 14:33:02 -05:00
WIP: extend the embed functionality

Add explicit null to headers or it will have to have every captcha file

perdedora commented on issue leftypol/leftypol#70 2025-03-01 09:03:15 -06:00
Thumbnail regen feature

This code is from kissu, to enable mods to regen thumbnails marked as spoiler: https://forgejo.leftypol.org/perdedora/nicochan_magali/src/branch/composer/inc/image.php#L630

perdedora commented on issue leftypol/leftypol#63 2025-02-21 09:43:38 -06:00
Thread Auto Update add double newline

Possible conflict between auto-reload.js and ajax.js

perdedora commented on issue leftypol/leftypol#108 2025-02-21 09:40:09 -06:00
Buggy op backlink

The bug is in this line: https://forgejo.leftypol.org/leftypol/leftypol/src/branch/config/js/show-backlinks.js#L18

Change to: let replyId = $(this).attr('id').split('_')[1];

perdedora commented on issue leftypol/leftypol#65 2025-02-20 17:32:05 -06:00
Better animated thumbs

All of our thumbnails are webp, including gifs which we convert to animated webp.

I could only make it work using convert. gif2webp was subpar for thumbnail because of resize options and ffmpeg…

perdedora commented on issue leftypol/leftypol#66 2025-02-20 17:27:15 -06:00
Add more embeds

For youtube shorts you could just replace /shorts/ for /watch?v=/ and it will work like a normal embed